Refactor and Query Discovery Mode #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to read a list of hosts from mysql_servers table instead of a single host from config file. This merges the old server.rs into the hosts file. This also remove the Pooled connection to a single connection. Fixes: #5
- Refactor the code to make it more readable and maintainable. Added
a new module `proxysql` to handle all the proxysql related
functionalities.
- Refactor the code to use the `query` module to handle all the
query discovery related functionalities.
- Added Query Discovery configuration. Now users can specify the
query discovery mode in the configuration file. The set of rules
to discover the queries are defined in the README.md file.
Closes: #6
altmannmarcelo
force-pushed
the
query-search-method
branch
from
ee1c7f9 to
c114b91
Compare
davisjc
reviewed
Sep 6, 2024
Closed
altmannmarcelo
force-pushed
the
query-search-method
branch
from
146ac42 to
2fe8762
Compare
altmannmarcelo
force-pushed
the
query-search-method
branch
from
2fe8762 to
b9a2ba4
Compare
davisjc
reviewed
Sep 9, 2024
| /// A boolean indicating if the rule was added successfully. | ||
| pub fn add_as_query_rule(&mut self, query: &Query) -> Result<bool, mysql::Error> { | ||
| let datetime_now: DateTime<Local> = Local::now(); | ||
| let date_formatted = datetime_now.format("%Y-%m-%d %H:%M:%S"); |
There was a problem hiding this comment.
Do we also need to write the time zone here?
There was a problem hiding this comment.
No need to complicate here. This will always be run on the same ProxySQL server, so no timezone diff.
There was a problem hiding this comment.
I'm only bringing this up because I see we're decoding some time zone below with %z. That seems okay?
altmannmarcelo
force-pushed
the
query-search-method
branch
from
b9a2ba4 to
962db6c
Compare
davisjc
reviewed
Sep 9, 2024
| .trim(); | ||
| let datetime_mirror_str = format!("{} {}", datetime_mirror_str, tz); | ||
| let datetime_mirror_rule = | ||
| DateTime::parse_from_str(datetime_mirror_str.as_str(), "%Y-%m-%d %H:%M:%S %z") |
There was a problem hiding this comment.
This is the time zone decoding line I'm talking about.
There was a problem hiding this comment.
ah, ok - parse_from_str requires a TZ and we use localTZ.
There was a problem hiding this comment.
Ah I see. I missed the part where we append the time zone to the string after we fetch it from ProxySQL.
| /// A boolean indicating if the rule was added successfully. | ||
| pub fn add_as_query_rule(&mut self, query: &Query) -> Result<bool, mysql::Error> { | ||
| let datetime_now: DateTime<Local> = Local::now(); | ||
| let date_formatted = datetime_now.format("%Y-%m-%d %H:%M:%S"); |
There was a problem hiding this comment.
I'm only bringing this up because I see we're decoding some time zone below with %z. That seems okay?
Fixed review comments in hosts and proxysql.cnf files. Added measure unit to README.md to clarify the values are measured by proxysql using microseconds.
altmannmarcelo
force-pushed
the
query-search-method
branch
from
962db6c to
f451645
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the code to make it more readable and maintainable. Added
a new module
proxysqlto handle all the proxysql relatedfunctionalities.
Refactor the code to use the
querymodule to handle all thequery discovery related functionalities.
Added Query Discovery configuration. Now users can specify the
query discovery mode in the configuration file. The set of rules
to discover the queries are defined in the README.md file.