Limit number of caches #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvzink
reviewed
Aug 13, 2024
src/queries.rs
Outdated
| config.readyset_user, | ||
| (config.number_of_queries * 2) | ||
| )) | ||
| .expect("Failed to query proxysql_conn"); |
There was a problem hiding this comment.
This error is now ambiguous; could make it more descriptive and say which query is failing.
There was a problem hiding this comment.
Good point. Fixed.
| LIMIT {}", | ||
| config.source_hostgroup, | ||
| config.readyset_user, | ||
| (config.number_of_queries * 2) |
There was a problem hiding this comment.
Possibly a stupid question, but why 2x? Just to have extras in case some can't be cached?
There was a problem hiding this comment.
No stupid. This is indeed to account for query not supported. We get twice as much queries we should cache and start testing them, stopping when we reach number_of_queries config.
This commit adds a configuration to limit the number of caches the tool will create. The default value is 10. Fixes #4
altmannmarcelo
force-pushed
the
issue-4
branch
from
cf61a51 to
c7e0c44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a configuration to limit the number of caches the tool will create.
The default value is 10.
Fixes #4