-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-305] Add app id to all web requests #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Some small things in comments, not blockers though. Probably wait until Raigo or Max have tested with gateway though
@@ -52,7 +52,7 @@ public static void ShowWindow() | |||
{ | |||
var window = GetWindow<SettingsEditor>(); | |||
window.titleContent = new GUIContent(SETTINGS); | |||
window.minSize = new Vector2(500, 580); | |||
window.minSize = new Vector2(500, 620); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love these inline, hard coded size values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any suggestions on how to restrict min size for window?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good
SDK-305
Description
How to Test
Checklist