Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-305] Add app id to all web requests #99

Merged
merged 3 commits into from
Aug 16, 2023
Merged

[SDK-305] Add app id to all web requests #99

merged 3 commits into from
Aug 16, 2023

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Aug 4, 2023

SDK-305

Description

  • Added app id in core settings and settings window
  • App id is sent as header with all requests made from sdk

How to Test

  • Try to check if sent request contains the header

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk requested a review from bfercher August 4, 2023 11:24
@rYuuk rYuuk changed the title Feature/app [SDK-305] Add app id to all web requests Aug 7, 2023
@rYuuk rYuuk self-assigned this Aug 7, 2023
@rYuuk rYuuk marked this pull request as ready for review August 8, 2023 11:50
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Some small things in comments, not blockers though. Probably wait until Raigo or Max have tested with gateway though

@@ -52,7 +52,7 @@ public static void ShowWindow()
{
var window = GetWindow<SettingsEditor>();
window.titleContent = new GUIContent(SETTINGS);
window.minSize = new Vector2(500, 580);
window.minSize = new Vector2(500, 620);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love these inline, hard coded size values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggestions on how to restrict min size for window?

Runtime/Utils/WebRequestDispatcher.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@rk132 rk132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good

@rYuuk rYuuk merged commit fb46c45 into develop Aug 16, 2023
@rYuuk rYuuk deleted the feature/app-id branch August 16, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants