Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Response and specify the type needed to avoid extra allocation coming from DownloadHandler.Text #314

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

abaza121
Copy link
Contributor

TICKETID

Description

  • Briefly describe what this change will do
    There is an issue with avatar loader when cache is disabled this is meant to fix it by avoiding the call to downloadHandler.Text when attempting to push it.

How to Test

  • Attempt to load avatar with caching disable and observe a spike in profiler
  • With this PR observe no spike is happening.

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@abaza121 abaza121 requested a review from a team as a code owner August 27, 2024 09:02
@HarrisonHough HarrisonHough changed the base branch from main to develop August 27, 2024 09:07
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice catch!

@HarrisonHough HarrisonHough merged commit 72b081e into readyplayerme:develop Aug 29, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants