Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add bones, if bones are not set #310

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented Jul 12, 2024

TICKETID

Description

  • Briefly describe what this change will do

How to Test

  • Add steps to locally test these changes

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rk132 rk132 requested a review from a team as a code owner July 12, 2024 11:48
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I think I remember that previously I worked around this by assigning a mesh in the prefab then unassigned the mesh and left the root bone and it seemed to keep all the bones. But this approach should be better, more null safe at least

@rk132 rk132 merged commit 9d0ee93 into release/v7.1.0 Jul 15, 2024
4 checks passed
@rk132 rk132 deleted the fix/update-mesh-with-bones-if-null branch July 15, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants