Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/shader override update #306

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Feature/shader override update #306

merged 7 commits into from
Jul 8, 2024

Conversation

HarrisonHough
Copy link
Collaborator

TICKETID

Description

  • This PR reworks the shader override functionality to support multiple property types, (Previously it was only textures). This enables the proper transfer of correct values like metallic and roughness

How to Test

  • Add a shader override to an Avatar Config
  • Enter in correct target property names (these can be found by selecting your shader and looking at the property names)
  • assign the config in RPM Settings window
  • Load an avatar from RPM Avatar loader window
  • Check that values properly mapped

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team as a code owner July 5, 2024 10:46
rk132
rk132 reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@rk132 rk132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values are not updated in the shader

rk132
rk132 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@rk132 rk132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rk132
Copy link
Contributor

rk132 commented Jul 8, 2024

Looks good

One improvement regarding warnings is that when the field is empty, don't show warnings

@HarrisonHough
Copy link
Collaborator Author

Looks good

One improvement regarding warnings is that when the field is empty, don't show warnings

yes good point will add that.

@HarrisonHough HarrisonHough merged commit 67cb3b3 into develop Jul 8, 2024
@HarrisonHough HarrisonHough deleted the feature/shader-override-update branch July 8, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rk132 rk132 rk132 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarrisonHough @rk132