Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/merge anonymous accounts to rpm prompt #219

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Feature/merge anonymous accounts to rpm prompt #219

merged 4 commits into from
Feb 9, 2024

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented Feb 8, 2024 •
edited
Loading

image

SDK-759

Description

  • Add a dialog for the user, when he logs in, that if he wants to merge their current session to their RPM account.

How to Test

  • Create an avatar with your anonymous account and try to merge with/without merging assets and avatars

@rk132 rk132 requested a review from a team as a code owner February 8, 2024 09:29
HarrisonHough
HarrisonHough approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. some small suggestions in the comments to simplify some functions into 1.

Runtime/AvatarCreator/Scripts/UI/Elements/LoginElement.cs Outdated Show resolved Hide resolved
...tarCreatorSamples/AvatarCreatorWizard/Scripts/UI/SelectionScreens/LoginWithEmailSelection.cs Show resolved Hide resolved
@rk132 rk132 merged commit 845e077 into develop Feb 9, 2024
@rk132 rk132 deleted the feature/merge-anonymous-accounts-to-RPM-prompt branch February 9, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rk132 @HarrisonHough