Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rpm-source header to the requests #214

Merged
merged 1 commit into from
Feb 2, 2024
Merged

feat: add rpm-source header to the requests #214

merged 1 commit into from
Feb 2, 2024

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented Feb 1, 2024 •
edited by jira bot
Loading

SDK-627

Description

  • Add rpm-source header to the requests. This is used to track the usage of avatar creator.

How to Test

  • Right now save draft endpoint processes this data. Check, that if you save the draft in the avatar creator, that in amplitude, there will be one extra entry. (This is cached for 12 hours, so you can make only one request)

@rk132 rk132 requested a review from a team as a code owner February 1, 2024 12:23
HarrisonHough
HarrisonHough approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rk132 rk132 merged commit d1268bd into develop Feb 2, 2024
6 checks passed
@rk132 rk132 deleted the feature/track-draft-saving-endpoint branch February 2, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rk132 @HarrisonHough