refactor: package event listener #177
Conversation
| [InitializeOnLoadMethod] | ||
| static void Initialize() | ||
| { | ||
| Events.registeringPackages += OnPackagesInstalled; | ||
| Events.registeredPackages += OnPackagesInstalled; |
There was a problem hiding this comment.
Are you sure this change was needed? 🤔
There was a problem hiding this comment.
Code looks fine and seems to work. I mentioned this to you already but I thought that it also worked before with the initial implementation, at least when I remember tested 😅. I remember complaining to Max about firing multiple events but then I realized it was because of the multiple packages or whatever
It was hard to find the events in Amplitude seems there is some delay with the sync or something
Yup, I remember the same - I spoke to @rYuuk about it and we were trying to understand if there was something about his local setup that prevented the other event from working for him, because I also went back to look at past Amplitude events and it definitely was also working previously too. |
not sure if relevant here but when calling stuff in editor via [InitializeOnLoadMethod] I find that behaviour for order of operations can differ per machine. In particular I notice the order is different on a mac. But there are also some errors or logs that show in different order depending on whether I use my personal laptop or work one 😅 |
- The model namespace caused PackageCoreInfo.cs to not come in same asmdef, hence causing error when it was used outside of this asmdef. - I made it simpler by removing redundant code and using simple string type.
## Description - The model namespace caused PackageCoreInfo.cs to no come in same asmdef, hence causing error when it was used outside of this asmdef. - I made it simpler by removing redundant code and using simple string type.
## Description - The model namespace caused PackageCoreInfo.cs to no come in same asmdef, hence causing error when it was used outside of this asmdef. - I made it simpler by removing redundant code and using simple string type.
Description