Feature/endpoint class refactor #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxAndreassenRPM
commented
Dec 1, 2023
| @@ -11,7 +11,7 @@ public static class AvatarRenderHelper | |||
| public static async Task<Texture2D> GetPortrait(string avatarId, CancellationToken token = default) | |||
| { | |||
| var webRequestDispatcher = new WebRequestDispatcher(); | |||
| var response = await webRequestDispatcher.SendRequest<ResponseTexture>(AvatarEndpoints.GetRenderEndpoint(avatarId), HttpMethod.GET, | |||
| var response = await webRequestDispatcher.SendRequest<ResponseTexture>($"{Env.RPM_MODELS_BASE_URL}/{avatarId}.png", HttpMethod.GET, | |||
There was a problem hiding this comment.
A small improvement I'd now make (but haven't done here yet) is to move this into the main avatar api class, since this class isn't a helper, it's just a class with another avatar api request in it.
HarrisonHough
approved these changes
Dec 1, 2023
| @@ -9,20 +9,21 @@ public class AuthAPIRequests | |||
| { | |||
| private readonly string domain; | |||
| private readonly IDictionary<string, string> headers = CommonHeaders.GetHeadersWithAppId(); | |||
| private readonly string rpmAuthBaseUrl; | |||
|
|
|||
| private readonly WebRequestDispatcher webRequestDispatcher; | |||
|
|
|||
| public AuthAPIRequests(string domain) | |||
There was a problem hiding this comment.
Is this domain = subdomain? and if so why is it not using core settings subdomain that is used everywhere else?
There was a problem hiding this comment.
It seems to be initialized with that value (see screenshot below):
I can update it if you think it makes sense to. Wasn't sure if it was done this way for a reason or not 🤔
HarrisonHough
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a draft PR for removing the concept of endpoint files whose sole purpose is to define the URLs for requests. In this PR, each lowest level SDK method fully encapsulates what it needs to make a request to the API, and so you only have to look in 1 place to understand how a request works. Furthermore, adding future requests now only requires you to add 1 new function, rather than update 2 classes each time.
This is PR is only a draft, as there was still some debate about this. However, I wanted to create a PR to illustrate how it would work. There is still other work to do, but my hope is that this is another step towards make the project structure of the SDK easier to digest and understand.