Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-618] Decouple input logic from rotate avatar script #169

Merged
merged 2 commits into from
Nov 30, 2023
Merged

[SDK-618] Decouple input logic from rotate avatar script #169

merged 2 commits into from
Nov 30, 2023

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Nov 29, 2023 •
edited by jira bot
Loading

SDK-618

Description

  • Extracted input logic to different script
  • Added interface for input logic

How to Test

  • Run avatar creator sample

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk self-assigned this Nov 29, 2023
@rYuuk rYuuk marked this pull request as ready for review November 30, 2023 05:47
@rYuuk rYuuk requested a review from a team as a code owner November 30, 2023 05:47
HarrisonHough
HarrisonHough approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me nice and simple. Cool stuff!

@rYuuk rYuuk merged commit 273fe5c into develop Nov 30, 2023
@rYuuk rYuuk deleted the feature/rotate-avatar-refactor branch November 30, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees

@rYuuk rYuuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rYuuk @HarrisonHough