Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-626] Feature/webgl helper update #158

Merged
merged 6 commits into from
Nov 22, 2023
Merged

[SDK-626] Feature/webgl helper update #158

merged 6 commits into from
Nov 22, 2023

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Nov 20, 2023 •
edited by jira bot
Loading

SDK-626

Description

  • Reworks how the auto setup functionality works when importing webGL sample as WebGLHelper also must be in Assets/Plugins folder to work.
  • So this PR adds the auto moving of this folder
  • It also moves the folder rather than copies. This is better as you don't end up with file duplicates and that not only bloats the project but causes issues with duplicate GUIDs

How to Test

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team as a code owner November 20, 2023 09:58
rk132
rk132 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@rk132 rk132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HarrisonHough HarrisonHough merged commit 7208ed3 into develop Nov 22, 2023
4 checks passed
@HarrisonHough HarrisonHough deleted the feature/webgl-helper-update branch November 22, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rk132 rk132 rk132 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarrisonHough @rk132