Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-573] Add show sample button in guide #141

Merged
merged 6 commits into from
Oct 31, 2023
Merged

[SDK-573] Add show sample button in guide #141

merged 6 commits into from
Oct 31, 2023

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Oct 30, 2023 •
edited
Loading

SDK-573

Description

  • Added button in integration guide to load avatar creator sample
  • Extracted sample loader into separate script
  • Add analytics event when sample is loaded

How to Test

  • Import package
  • Open integration guide
  • Click on load sample scene

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk self-assigned this Oct 30, 2023
@rYuuk rYuuk requested a review from a team as a code owner October 30, 2023 13:49
HarrisonHough
HarrisonHough approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!
Nice idea removing that obsolete folder
Cool stuff

@rYuuk rYuuk changed the title Feature/avatar creator button in guide [SDK-573] Add show sample button in guide Oct 31, 2023
@rYuuk rYuuk merged commit c08b4b1 into develop Oct 31, 2023
@rYuuk rYuuk deleted the feature/avatar-creator-button-in-guide branch October 31, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees

@rYuuk rYuuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rYuuk @HarrisonHough