Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-562] Merge avatar creator into core #135

Merged
merged 12 commits into from
Oct 25, 2023
Merged

[SDK-562] Merge avatar creator into core #135

merged 12 commits into from
Oct 25, 2023

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Oct 20, 2023 •
edited by jira bot
Loading

SDK-562

Description

  • Merged avatar creator into core
  • Renamed avatar creator sample to sample creator

How to Test

  • Try sample creator

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk self-assigned this Oct 20, 2023
@rYuuk rYuuk force-pushed the feature/merge-avatar-creator branch from 67e8375 to 6f37cc3 Compare October 24, 2023 12:13
@rYuuk rYuuk changed the title Feature/merge avatar creator [SDK-562] Merge avatar creator into core Oct 24, 2023
@rYuuk rYuuk marked this pull request as ready for review October 24, 2023 12:27
@rYuuk rYuuk requested a review from a team as a code owner October 24, 2023 12:27
HarrisonHough
HarrisonHough approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually looks all good. But I think before we merge we should have a quick discussion as a team about sample naming and structure (in regards to how to handle multiple creator examples)

package.json Outdated Show resolved Hide resolved
@rYuuk rYuuk requested a review from HarrisonHough October 25, 2023 09:22
HarrisonHough
HarrisonHough approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! awesome work 👏

@rYuuk rYuuk merged commit 60db740 into develop Oct 25, 2023
@rYuuk rYuuk deleted the feature/merge-avatar-creator branch October 25, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees

@rYuuk rYuuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rYuuk @HarrisonHough