Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-381] add test for avatar loader window #110

Merged
merged 2 commits into from
Sep 3, 2023

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented Aug 28, 2023

SDK-381

Description

  • add test to verify, that the prefab created is a directly linked to object in world without overrides or changes.

How to Test

  • Add steps to locally test these changes
  • Add steps to locally test these changes

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rk132 rk132 changed the title Feature/add test for avatar loader window [SDK-381] add test for avatar loader window Aug 28, 2023
@rk132 rk132 changed the base branch from main to develop August 28, 2023 11:10
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a super interesting way of testing it.
I realize now that I should have put more specific information in this task, I mostly didn't as I assumed it would go to me.
But in any case, you could probably simplify this a lot and just testing this function.

image

Impementation would be like:

  1. Load avatar
  2. Run prefab creation function on avatar
  3. Load prefab from resources
  4. Check all skinmesh != null
    @rYuuk what do you think?

Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so I think that the Avatar Loader window test is good, but we should still also add a test to specifically call the CreateAvatarPrefab function.

The test would basically need to do this

  1. Load avatar
  2. Run prefab creation function on avatar
  3. Load prefab from resources
  4. Check all skinmesh != null

(feel free to adjust or simplify as you wish)

Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was gonna ask why the extra param was added, but then I realized it was because of the test :D
Nice work!

@rk132 rk132 merged commit 9468d81 into develop Sep 3, 2023
@rk132 rk132 deleted the feature/add_test_for_avatar_loader_window branch September 3, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants