Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Basic Antora page #11783

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Docs: Basic Antora page #11783

wants to merge 4 commits into from

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 20, 2024

This is just a basic outline pointing at our existing test-builds content.

Build on top of #11782 to keep things simple to merge this after that.


📚 Documentation previews 📚

This highlights the test-builds repo,
and contains the basic config to make it build on RTD.

This doesn't address any integration info,
but I wanted to get a basic page up to start getting SEO.
This is just a basic outline pointing at our existing test-builds content.
@ericholscher ericholscher requested a review from a team as a code owner November 20, 2024 23:53
@ericholscher ericholscher changed the title Antora-docs Docs: Basic Antora page Nov 20, 2024
Base automatically changed from markdoc-docs to main November 25, 2024 16:51
@ericholscher ericholscher requested a review from humitos November 25, 2024 17:44
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there are changes for Markdoc that need to be removed from this PR.

Comment on lines +18 to +20
os: ubuntu-22.04
tools:
nodejs: "20"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
os: ubuntu-22.04
tools:
nodejs: "20"
os: ubuntu-24.04
tools:
nodejs: "22"

@@ -0,0 +1,87 @@
Markdoc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you pushed Markdoc changes by mistake in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants