Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docusaurus basics #11752

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Docusaurus basics #11752

merged 8 commits into from
Nov 26, 2024

Conversation

plaindocs
Copy link
Contributor

@plaindocs plaindocs commented Nov 7, 2024

Not a lot of info here, but probably worth pushing out anyway


📚 Documentation previews 📚

@plaindocs plaindocs requested a review from a team as a code owner November 7, 2024 15:41
@plaindocs plaindocs requested review from humitos and removed request for a team and ericholscher November 7, 2024 15:43
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand, docosaurus renders the docs with JS, that has the downside of some of our integrations that work over the generated HTML not working, like search and content embedding. Maybe have a limitations section?

@plaindocs
Copy link
Contributor Author

@stsewd yup, sounds good, thanks

@humitos
Copy link
Member

humitos commented Nov 11, 2024

like search and content embedding

File Tree Diff won't work here either...

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As Santos mentioned, we should add a "Limitations" section before merging.

Comment on lines +22 to +33
commands:
# "docs/" was created following the Docusaurus tutorial:
# npx create-docusaurus@latest docs classic
# but you can just use your existing Docusaurus site
#
# Install Docusaurus dependencies
- cd docs/ && npm install
# Build the site
- cd docs/ && npm run build
# Copy generated files into Read the Docs directory
- mkdir --parents $READTHEDOCS_OUTPUT/html/
- cp --recursive docs/build/* $READTHEDOCS_OUTPUT/html/
Copy link
Member

@humitos humitos Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we merge and deploy #11710 this would be as following:

build:
  install:
    - cd docs/ && npm install
  build:
    html:
      - cd docs/ && npm run build
  post_build:
    - mkdir --parents $READTHEDOCS_OUTPUT/html/
    - cp --recursive docs/build/* $READTHEDOCS_OUTPUT/html/

@ericholscher
Copy link
Member

I'm 👍 on merging this now, so we can start getting some SEO from it.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on the fence about the "Supported features" section. I'd probably remove it.

However, if we want to communicate what things don't work, I would probably re-phrase it as "Limitations" instead and only mention the things that don't work. That way, we don't need to repeat this list in all the pages of the documentation tools, and it's clearer what it doesn't work.

I think we should point all users to the addons index page for all the common features and each "Limitation" section should list only those that don't work.

My $0.02

@humitos
Copy link
Member

humitos commented Nov 25, 2024

By the way, in particular the example from Markdoc "Supported features" doesn't add too much value IMO and just adds confusions, since all the addons are listed there: https://github.com/readthedocs/readthedocs.org/pull/11782/files#diff-cb2fa2b006a3f660a46f7668df27803630c69192df00ca6f2da29bfb4f14464fR62

However, it doesn't mentioning redirects, environment variables, automation rules and a bunch of other features we do support for all the doctools. That's why I'm saying I'd prefer to remove the section and/or re-phrase it as "Limitations" instead. I think it will be clearer that only a subset of features are not supported.

@plaindocs
Copy link
Contributor Author

plaindocs commented Nov 26, 2024

I think a step back and a moment to consider the Supported Features is useful here. Are we sure it's clear to readers whether we're talking about RTD Features or Docusaurus Features?

We definitely don't want to add all of those to the Addons index, it'll get real busy, especially when we start adding more entries. So in general I'm in agreement with @humitos comments above.

But I also think we can merge and iterate.

@ericholscher
Copy link
Member

I do think we want to highlight the features that work as a good way of marketing. If the goal of these pages is SEO, then people landing on it won't know about our platform features, so highlighting them is good. I do agree though that we probably want to frame this in a bit of a different way, and perhaps the website pages are where we're doing some of that work. So I've gone ahead and renamed it to limitations for now.

@ericholscher ericholscher enabled auto-merge (squash) November 26, 2024 15:10
@ericholscher ericholscher merged commit 777eb1a into main Nov 26, 2024
3 of 5 checks passed
@ericholscher ericholscher deleted the sam/docusaurus branch November 26, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants