Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link website from docs sidebar #11426

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Link website from docs sidebar #11426

merged 1 commit into from
Jun 19, 2024

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Jun 18, 2024 •
edited
Loading

Refs readthedocs/website#286

📚 Documentation previews 📚

@ericholscher ericholscher requested a review from a team as a code owner June 18, 2024 22:50
@ericholscher ericholscher requested a review from agjohnson June 18, 2024 22:50
agjohnson
agjohnson approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This nav item gets clipped without anything below it, unfortunately. Not sure why that is:

image

@ericholscher
Copy link
Member Author

Yea, seems like not an issue here though, so at least a baby step :)

@ericholscher ericholscher merged commit 44a7476 into main Jun 19, 2024
8 checks passed
@ericholscher ericholscher deleted the link-site branch June 19, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees

@ericholscher ericholscher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @agjohnson