-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The python.install
requires the path
key
#11300
Conversation
…th` (#11301) This confused me initially because I was looking in https://docs.readthedocs.io/en/stable/config-file/v2.html#packages for `python.install.package`, which simply doesn't exist. Instead, this should probably be `python.install.path` which _is_ a required key (#11300), and defaults to `pip`.
I'm pinging @stsewd here since I think that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. And how it's currently documented, we separate both options in different sections (requirements file and packages).
Can we also change the requirements key to also be marked as required in the docs, so it's consistent with this change?
Actually, looks like we changed these in #10303 |
Afraid I'm not actually sure what the best outcome is here... all I know is that:
So there's an apparent inconsistency between the schema and docs... But I get what you're saying @humitos that really what's required is to have either the If my understanding is correct, then perhaps the schema file is actually what needs updating? readthedocs.org/readthedocs/rtd_tests/fixtures/spec/v2/schema.json Lines 277 to 278 in cb50bbf
And then perhaps clarify in the docs that "one of either |
I like the suggestion from #10303 (comment), writing "required when..."
Schema is fine, we have two installation methods, and each requires a different key, we could have used two different "parent keys" so they don't share the same parent key, but that ship already sailed... |
I'm not sure there's a clear next action here, as documenting this solely for conda feels weird to me... so I'm going to close this. |
The
path
key seems to be required per:readthedocs.org/readthedocs/rtd_tests/fixtures/spec/v2/schema.json
Lines 277 to 278 in cb50bbf
📚 Documentation previews 📚
docs
): https://docs--11300.org.readthedocs.build/en/11300/dev
): https://dev--11300.org.readthedocs.build/en/11300/