-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New dashboard: notification to point users there #11161
Conversation
We can add the notifications to all the users by running the following code: ```python from readthedocs.core.notifications import MESSAGE_BETA_DASHBOARD_AVAILABLE for user in User.objects.all(): Notification.objects.add( message_id=MESSAGE_BETA_DASHBOARD_AVAILABLE, attached_to=user, dismissable=True, ) ``` This will show a one-time dismissable notification to these users. In the future (weeks, months) if we can show them another notification like this one as a reminder, we can run the same code again. Related readthedocs/ext-theme#183
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have questions on the UX here, and ultimately still lean towards adding a link on the build page next.
I worry that this notification will be visible on the new dashboard as users log in to the instance or click the notification to log in. Is there a way that we can filter this out from the new dashboard?
I updated the notification to show a different message when it's show on the new dashboard. Old dashboardIt says the new dashboard is available with a link to it. New dashboardIt says there may be issues and ask for feedback to the user. |
{% if RTD_EXT_THEME_ENABLED %} | ||
This dashboard is currently in beta, | ||
you can <a href="https://{{ PRODUCTION_DOMAIN }}">return to the legacy dashboard</a> if you encounter any problems. | ||
Feel free to <a href="https://{{ PRODUCTION_DOMAIN }}/support/">report any feedback</a> you may have. | ||
{% else %} | ||
Our new <strong>beta dashboard</strong> is now available for testing. | ||
<a href="https://beta.{{ PRODUCTION_DOMAIN }}/">Give it a try</a> and send us feedback. | ||
{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯
I knew we were using templating, but I somehow totally missed the fact we could use template logic in the notification. This is fantastic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic
"Fantastic" is a big word, tho. I think saying a "nice hack" fits better here 😝
Co-authored-by: Anthony <[email protected]>
We can add the notifications to all the users by running the following code:
This will show a one-time dismissable notification to these users.
In the future (weeks, months) if we want to show them another notification like this
one as a reminder, we can run the same code again.
Related readthedocs/ext-theme#183
Related readthedocs/ext-theme#284