Build: add support for Ruby #11075
Merged
Build: add support for Ruby #11075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Jan 29, 2024
Comment on lines
+335
to
+336
| :Options: | ||
| - ``3.3`` |
There was a problem hiding this comment.
I think it's reasonable to only start with a single version. Should we have a small note saying you can ask support for additional versions? 🤷
There was a problem hiding this comment.
I think that people will naturally ask for more versions (and tools) as they have been doing 😄 without the need of a note 😅
humitos
added
Status: blocked
|
This is unblocked now. Everything is on its place and we should be able to merge this PR and deploy it next week. |
stsewd
reviewed
Feb 1, 2024
There was a problem hiding this comment.
We are missing updating our schema https://github.com/readthedocs/readthedocs.org/blob/main/readthedocs/rtd_tests/fixtures/spec/v2/schema.json
|
I'm updating the schema at 57e1b89 |
|
@stsewd thanks! 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10346
Requires readthedocs/readthedocs-docker-images#200
Requires readthedocs/readthedocs-docker-images#202
Requires https://github.com/readthedocs/readthedocs-ops/pull/1440
📚 Documentation previews 📚
docs): https://docs--11075.org.readthedocs.build/en/11075/dev): https://dev--11075.org.readthedocs.build/en/11075/