Proxito: always use subdomain for serving docs #10799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Oct 5, 2023
Comment on lines
-206
to
-207
| or "localhost" in request.get_host() | ||
| or "testserver" in request.get_host() |
There was a problem hiding this comment.
These two checks are not really that useful, and they cause problems if your project has localhost in its name.
There was a problem hiding this comment.
Hrm, I feel like it might cause some issues in tests, but if everythings looks OK, I agree this is a better approach.
ericholscher
approved these changes
Oct 9, 2023
| @@ -122,11 +113,6 @@ def resolve_path( | |||
| filename = self._fix_filename(filename) | |||
|
|
|||
| parent_project, project_relationship = self._get_canonical_project_data(project) | |||
| cname = ( | |||
There was a problem hiding this comment.
Do we not still need this logic to determine cname usage?
There was a problem hiding this comment.
Not when resolving the path, only when resolving the domain
Comment on lines
-206
to
-207
| or "localhost" in request.get_host() | ||
| or "testserver" in request.get_host() |
There was a problem hiding this comment.
Hrm, I feel like it might cause some issues in tests, but if everythings looks OK, I agree this is a better approach.
Co-authored-by: Eric Holscher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10767
📚 Documentation previews 📚
docs): https://docs--10799.org.readthedocs.build/en/10799/dev): https://dev--10799.org.readthedocs.build/en/10799/