Addons: return the .first() object (#10868)

* Addons: return the `.first()` object

Builds are sorted by `-date` by default, so we need the `.first()` instead of
the `.last()`.

* Test case for `builds.current` being the latest successful one

readthedocs/proxito/tests/test_hosting.py

@@ -8,6 +8,7 @@
 from django.contrib.auth.models import User
 from django.test import TestCase, override_settings
 from django.urls import reverse
+from django.utils import timezone
 
 from readthedocs.builds.constants import LATEST
 from readthedocs.builds.models import Build, Version
@@ -403,6 +404,50 @@ def test_flyout_single_version_project(self):
         ]
         assert r.json()["addons"]["flyout"]["downloads"] == expected
 
+    def test_builds_current_is_latest_one(self):
+        # Create 10 successful build objects
+        # The latest one (ordered by date) will be ``a1b2c3-9``
+        for i in range(10):
+            fixture.get(
+                Build,
+                date=timezone.now(),
+                project=self.project,
+                version=self.version,
+                commit=f"a1b2c3-{i}",
+                length=60,
+                state="finished",
+                success=True,
+            )
+
+        # Latest failed build
+        fixture.get(
+            Build,
+            date=timezone.now(),
+            project=self.project,
+            version=self.version,
+            commit=f"a1b2c3-failed",
+            length=60,
+            state="finished",
+            success=False,
+        )
+
+        r = self.client.get(
+            reverse("proxito_readthedocs_docs_addons"),
+            {
+                "url": "https://project.dev.readthedocs.io/en/latest/",
+                "client-version": "0.6.0",
+                "api-version": "0.1.0",
+            },
+            secure=True,
+            headers={
+                "host": "project.dev.readthedocs.io",
+            },
+        )
+        assert r.status_code == 200
+
+        # ``a1b2c3-9``is the latest successful build object created
+        assert r.json()["builds"]["current"]["commit"] == "a1b2c3-9"
+
     def test_project_subproject(self):
         subproject = fixture.get(
             Project,

readthedocs/proxito/views/hosting.py

@@ -97,7 +97,7 @@ def _resolve_resources(self):
                 build = version.builds.filter(
                     success=True,
                     state=BUILD_STATE_FINISHED,
-                ).last()
+                ).first()
 
             except UnresolverError as exc:
                 # If an exception is raised and there is a ``project`` in the
@@ -113,7 +113,7 @@ def _resolve_resources(self):
             project = Project.objects.filter(slug=project_slug).first()
             version = Version.objects.filter(slug=version_slug, project=project).first()
             if version:
-                build = version.builds.last()
+                build = version.builds.first()
 
         return project, version, build, filename