-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications: show attached to User
, Project
and Organization
#261
Notifications: show attached to User
, Project
and Organization
#261
Conversation
Render notifications attached to these objects. This is the first pass of this work and there are some things we need to make decisions and improve. - Where (what pages) these notifications should render? - How "global" they should be considered? Note we are rendering these notifications in the template for now, but in the future they will be rendered using the APIv3: #259 Closes #260
bbfd72c
to
3e31aa6
Compare
I'm showing all the notifications attached to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we should keep all of the notifications in the same location on the page for now, except for the special location in the build detail page. It will be a little more confusing if there are user and project notifications, as these would display at two different points in the page.
I would put the project/organization notifications at the top of the content page, above the project/organization header. I could see us revisiting this later though.
readthedocsext/theme/templates/organizations/partials/header.html
Outdated
Show resolved
Hide resolved
Done in 84073ef It looks like this now: |
readthedocsext/theme/templates/organizations/partials/header.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Anthony <[email protected]>
Render notifications attached to these objects.
This is the first pass of this work and there are some things we need to make decisions and improve.
Note we are rendering these notifications in the template for now, but in the future they will be rendered using the APIv3: #259
Screenshots
User
Project
Organization
Closes #260