Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: EthicalAds: Default to fixedfooter for smaller screens #447

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Draft: EthicalAds: Default to fixedfooter for smaller screens #447

wants to merge 3 commits into from

Commits on Nov 22, 2024

  1. Default to fixedfooter for smaller screens 

    This is something I've wanted for a little while.
I don't think we're quite ready to ship it,
but I think it makes sense in a lot of cases.

I'm generally becoming more excited about this placement,
especially when the floating one is pretty intrusive.
    @ericholscher
    ericholscher committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    e20096a View commit details
    Browse the repository at this point in the history

  2. Small fixes

    @ericholscher
    ericholscher committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f55803e View commit details
    Browse the repository at this point in the history

  3. Note it's a hack

    @ericholscher
    ericholscher committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b9e342e View commit details
    Browse the repository at this point in the history