Fixes issue with text clipping from page turning. Fixes #283 #288
Conversation
matwood
commented
Apr 26, 2016
•
matwood
commented
- With certain window sizes the left text gets cut off from rounding
- on the page slide size.
* With certain window sizes the left text gets cut off from rounding * on the page slide size.
| @@ -693,7 +693,7 @@ var ReflowableView = function(options, reader){ | |||
| _$htmlBody.css('padding', 0); | |||
|
|
|||
| _paginationInfo.rightToLeft = _spine.isRightToLeft(); | |||
|
|
|||
| _paginationInfo.pageOffsetSize = _htmlBodyIsVerticalWritingMode ? _lastViewPortSize.height : (_lastViewPortSize.width + _paginationInfo.columnGap); | |||
There was a problem hiding this comment.
Interesting, _htmlBodyIsVerticalWritingMode ? _lastViewPortSize.height : (_lastViewPortSize.width + _paginationInfo.columnGap) replaces (_paginationInfo.columnWidth + _paginationInfo.columnGap) * _paginationInfo.visibleColumnCount (see onPaginationChanged_() _paginationInfo.pageOffset = _paginationInfo.pageOffsetSize * _paginationInfo.currentSpreadIndex; in the source above) where _paginationInfo.columnWidth was Math.round(((_htmlBodyIsVerticalWritingMode ? _lastViewPortSize.height : _lastViewPortSize.width) - _paginationInfo.columnGap * (_paginationInfo.visibleColumnCount - 1)) / _paginationInfo.visibleColumnCount); ... I have to look at the arithmetics to make sure this does not affect vertical writing mode, or some other column-gap related edge-case computations :)
danielweck
changed the title
danielweck
changed the title
|
Competing solution? #188 |
