Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translate cache #710

Merged
merged 15 commits into from
Jul 11, 2024
Merged

Conversation

FelixFern
Copy link
Contributor

Closes #676

Description

Translate the reference/react/cache
Page URL: https://id.react.dev/reference/react/cache

Copy link

vercel bot commented Jun 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
id-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 2:06am

Copy link

github-actions bot commented Jun 30, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@FelixFern
Copy link
Contributor Author

please kindly review @resir014

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of review, please check! @FelixFern

src/content/reference/react/cache.md Outdated Show resolved Hide resolved
src/content/reference/react/cache.md Outdated Show resolved Hide resolved
src/content/reference/react/cache.md Outdated Show resolved Hide resolved
src/content/reference/react/cache.md Outdated Show resolved Hide resolved
@FelixFern
Copy link
Contributor Author

First pass of review, please check! @FelixFern

changes committed, please recheck @resir014

@FelixFern FelixFern requested a review from resir014 July 4, 2024 08:59
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix grammar quality issue.

src/content/reference/react/cache.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix some more grammar quality issues.

src/content/reference/react/cache.md Outdated Show resolved Hide resolved
src/content/reference/react/cache.md Outdated Show resolved Hide resolved
src/content/reference/react/cache.md Outdated Show resolved Hide resolved
src/content/reference/react/cache.md Outdated Show resolved Hide resolved
src/content/reference/react/cache.md Outdated Show resolved Hide resolved
@FelixFern
Copy link
Contributor Author

Changes commited ya mas @mhaidarhanif , please recheck thank you!

Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now

@mhaidarhanif
Copy link
Collaborator

@resir014 can check again to approve

@resir014 resir014 merged commit f65d88b into reactjs:main Jul 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache
4 participants