Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translate introduction of escape hatches #522

Merged
merged 18 commits into from
Nov 4, 2023

Conversation

eriansha
Copy link
Contributor

@eriansha eriansha commented May 1, 2023

Closes #386

Description

Translate the escape hatches page.
Page URL: https://react.dev/learn/escape-hatches

@eriansha eriansha changed the title docs: translate introduction of escape hatches Docs: translate introduction of escape hatches May 1, 2023
@eriansha eriansha force-pushed the docs/translation/escape-hatches branch from 6f2180f to ff9fbb6 Compare July 9, 2023 07:25
@github-actions
Copy link

github-actions bot commented Jul 9, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[[...markdownPath]] 79.25 KB (🟡 +3 B) 183.2 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor non-blocking change required. Please check them out. @eriansha

src/content/learn/escape-hatches.md Outdated Show resolved Hide resolved
@resir014 resir014 changed the title Docs: translate introduction of escape hatches docs: translate introduction of escape hatches Oct 29, 2023
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvements

src/content/learn/escape-hatches.md Outdated Show resolved Hide resolved
src/content/learn/escape-hatches.md Outdated Show resolved Hide resolved
src/content/learn/escape-hatches.md Outdated Show resolved Hide resolved
@resir014
Copy link
Member

resir014 commented Nov 3, 2023

Hi @eriansha, do you have time to make the requested changes?

@eriansha
Copy link
Contributor Author

eriansha commented Nov 3, 2023

Hi @eriansha, do you have time to make the requested changes?

sure, sorry for delayed response.
i might create the changes on tommorrow 🙇🏻‍♂️

eriansha and others added 2 commits November 4, 2023 00:11
@eriansha
Copy link
Contributor Author

eriansha commented Nov 3, 2023

resolving @mhaidarhanif's comment. thank you to check small detail that i missed out 😄

Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eriansha You're welcome

@mhaidarhanif mhaidarhanif merged commit f52bcd9 into reactjs:main Nov 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape Hatches
3 participants