Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Indonesian Translation: Sharing State Between Components #370

Merged
merged 43 commits into from
May 1, 2023
Merged

New Indonesian Translation: Sharing State Between Components #370

merged 43 commits into from
May 1, 2023

Conversation

yaffalhakim1
Copy link
Contributor

@yaffalhakim1 yaffalhakim1 commented Apr 28, 2023 •
edited by zainfathoni
Loading

Hi, this PR is for #330
New translation for page Sharing State Between Components

Closes #381

@yaffalhakim1 yaffalhakim1 changed the title Sharing state between components New Indonesian Translation: Sharing State Between Components Apr 28, 2023
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@yaffalhakim1 yaffalhakim1 mentioned this pull request Apr 28, 2023
Closed
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@yaffalhakim1
Copy link
Contributor Author

Hi mas @resir014 and maintainers. This pr is ready to review. You can check in this commits:

@yaffalhakim1 yaffalhakim1 marked this pull request as ready for review April 29, 2023 04:01
resir014
resir014 previously requested changes Apr 29, 2023
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of code review. Here are some needed changes! @yaffalhakim1

src/content/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
src/content/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
src/content/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
src/content/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
src/content/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
src/content/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
@yaffalhakim1
Copy link
Contributor Author

First pass of code review. Here are some needed changes! @yaffalhakim1

alright mas, I will commit the suggestion ASAP while waiting for other maintainers to give their reviews.

@yaffalhakim1 @zainfathoni
Apply suggestions from code review
db83f98 
applying all suggestion from reviewers

Co-authored-by: Zain Fathoni <[email protected]>
@yaffalhakim1
Copy link
Contributor Author

Thanks for contributing! I have a few more suggestions here. 😁

surely, I missed a lot 😓, thank you for the review mas. ready to re-review

@yaffalhakim1 yaffalhakim1 requested a review from zainfathoni May 1, 2023 12:34
zainfathoni
zainfathoni approved these changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
Approved with a minor suggestion for paraphrasing. 😁

Thanks for contributing! 🙏

src/content/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
@mhaidarhanif mhaidarhanif dismissed resir014’s stale review May 1, 2023 23:41

there are already 3 review approvals

@mhaidarhanif mhaidarhanif merged commit 0d347ec into reactjs:main May 1, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@yaffalhakim1 @resir014
@mhaidarhanif @zainfathoni @r17x
docs: translate Sharing State Between Components (#370)
d0bcdff 
Co-authored-by: Resi Respati <[email protected]>
Co-authored-by: M Haidar Hanif <[email protected]>
Co-authored-by: Zain Fathoni <[email protected]>
Co-authored-by: Zain Fathoni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r17x r17x r17x approved these changes

@zainfathoni zainfathoni zainfathoni approved these changes

@mhaidarhanif mhaidarhanif mhaidarhanif approved these changes

@resir014 resir014 Awaiting requested review from resir014

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sharing State Between Components
5 participants
@yaffalhakim1 @mhaidarhanif @resir014 @zainfathoni @r17x