Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation for scaling up with reducer and context #364

Merged
merged 11 commits into from
May 1, 2023
Merged

translation for scaling up with reducer and context #364

merged 11 commits into from
May 1, 2023

Conversation

R1dwanMaulana
Copy link
Contributor

@R1dwanMaulana R1dwanMaulana commented Apr 28, 2023 •
edited by zainfathoni
Loading

Closes #385

translation for scaling up with reducer and context docs reference by #330

@r17x r17x self-requested a review April 28, 2023 22:42
r17x
r17x requested changes Apr 29, 2023
View reviewed changes
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
@rimamei rimamei mentioned this pull request Apr 30, 2023
Merged
@github-actions
Copy link

github-actions bot commented Apr 30, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif requested changes Apr 30, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvement.

src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
@mhaidarhanif mhaidarhanif requested a review from resir014 April 30, 2023 21:38
mhaidarhanif
mhaidarhanif requested changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion. Also wait for @r17x @mazipan @resir014 @zainfathoni to give final reviews.

src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
zainfathoni
zainfathoni requested changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!
I have a few minor suggestions. 😁

src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
zainfathoni
zainfathoni requested changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all my suggestions!
I have one final correction. Please address it, and don't forget to update it to the latest changes in the main branch, and it should be ready to merge! 💯

src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
zainfathoni
zainfathoni approved these changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
Thanks for contributing and addressing all the comments! 🙏

@zainfathoni zainfathoni requested a review from mhaidarhanif May 1, 2023 14:47
@mhaidarhanif mhaidarhanif merged commit e4bb45d into reactjs:main May 1, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@R1dwanMaulana @mhaidarhanif
@zainfathoni @r17x
docs: translation for scaling up with reducer and context (#364)
ea238c6 
Co-authored-by: M Haidar Hanif <[email protected]>
Co-authored-by: Zain Fathoni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazipan mazipan mazipan requested changes

@r17x r17x r17x approved these changes

@zainfathoni zainfathoni zainfathoni approved these changes

@mhaidarhanif mhaidarhanif mhaidarhanif approved these changes

@resir014 resir014 Awaiting requested review from resir014

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scaling Up with Reducer and Context
5 participants
@R1dwanMaulana @mhaidarhanif @zainfathoni @mazipan @r17x