Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete broken test #1911

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

TimothyMakkison
Copy link
Contributor

Looks like MockHttpMessageHandler.WithExactQueryString("&&&") will always return true, even if there aren't & symbols.

@TimothyMakkison TimothyMakkison marked this pull request as draft November 4, 2024 23:26
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.94%. Comparing base (6ebeda5) to head (9df3e62).
Report is 162 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1911      +/-   ##
==========================================
- Coverage   87.73%   84.94%   -2.80%     
==========================================
  Files          33       36       +3     
  Lines        2348     2504     +156     
  Branches      294      363      +69     
==========================================
+ Hits         2060     2127      +67     
- Misses        208      299      +91     
+ Partials       80       78       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimothyMakkison TimothyMakkison marked this pull request as ready for review November 5, 2024 23:07
@ChrisPulman ChrisPulman enabled auto-merge (squash) November 6, 2024 20:50
@ChrisPulman ChrisPulman merged commit c302e1c into reactiveui:main Nov 6, 2024
1 check passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants