Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix various bugs #702

Closed
wants to merge 4 commits into from
Closed

fix various bugs #702

wants to merge 4 commits into from

Conversation

willopez
Copy link
Member

Impact: minor
Type: bugfix

Issue

Fixes various small issues.

  1. The availablePaymentMethods query should not executed if the shop id is not yet available
  2. An error was being returned by an api route when the user was anonymous, it should not be an error, just a flag that says that the user is anonymous.
  3. Add a not about a know issue with the anonymous cart query being executed unnecessarily, this is due to a know issue with Apollo Client: "Skip" property of useQuery hook has no effect apollographql/react-apollo#3492

Testing

  1. Start with a fresh installation
  2. Observe and verify that the api route for /token is NOT returning an error on any view.
  3. Observe and verify that in the checkout page, the availablePaymentMethods query dose not return an error.

@willopez willopez requested a review from manueldelreal July 13, 2020 23:26
Signed-off-by: Will Lopez <[email protected]>
@willopez willopez closed this Jul 14, 2020
@kieckhafer kieckhafer deleted the willopez-fix-various-bugs branch September 21, 2020 22:10
@ryan-veracitek
Copy link

We're seeing this bug "The availablePaymentMethods query should not executed if the shop id is not yet available" and the above fix does not appear to have made it to the code. In our storefront we cannot click checkout as storeid becomes null & language becomes German.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants