Allow check fields and selectable fields to render as required #487 #581
Conversation
adamkudrna
force-pushed
the
bc/487-render-as-required
branch
from
47bcb52 to
0f3b935
Compare
|
I think the feature is good (we need it and we know why), but honestly the docs are very confusing to me. I think we should talk about it before merging - I will schedule this for our Monday meeting. |
I am approving this as it is fine for me. But I might be influenced by the reason for this change. But it is true that one more sentence could be helpful. I am missing the detailed explanation why would user might need this and why it is correct approach. |
Users may find themselves in a situation where the input is not required (i.e. making the input checked), but they also don't want to render the field as optional because not choosing an option can be perfectly valid. For this case, there is the `renderAsRequired` prop. This affects `CheckboxField`, `Radio`, `SelectField`, and `Toggle`. Closes #487
adamkudrna
force-pushed
the
bc/487-render-as-required
branch
from
0f3b935 to
7a65aab
Compare
| @@ -186,6 +186,76 @@ React.createElement(() => { | |||
| }); | |||
| ``` | |||
|
|
|||
| ### Required State | |||
There was a problem hiding this comment.
But it is true that one more sentence could be helpful. I am missing the detailed explanation why would user might need this and why it is correct approach.
I rewrote the docs and reworked the example. What do you guys think now?
There was a problem hiding this comment.
Suggestions:
- emphasize it's just a visual thing
- when a checkbox can be true or false, not only true
- consider moving it aside as an edge case
Users may find themselves in a situation where the input is not required (i.e. making the input checked), but they also don't want to render the field as optional because not choosing an option can be perfectly valid. For this case, there is the
renderAsRequiredprop.This affects
CheckboxField,Radio,SelectField, andToggle.Closes #487.