Leverage CSS cascade layers to fix and user-proof styles order #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbohal
approved these changes
Mar 8, 2024
|
Just wow! |
adamkudrna
force-pushed
the
feature/css-cascade-layers
branch
from
8a3a9a1 to
a5f44b0
Compare
adamkudrna
commented
Mar 8, 2024
adamkudrna
force-pushed
the
feature/css-cascade-layers
branch
from
a5f44b0 to
2c19ce8
Compare
mbohal
approved these changes
Mar 9, 2024
dacerondrej
approved these changes
Mar 11, 2024
bedrich-schindler
requested changes
Mar 19, 2024
Fixed, I forgot to rename nested TableCell styles. |
`css-loader` now only treats `*.module.*` files as CSS Modules.
adamkudrna
force-pushed
the
feature/css-cascade-layers
branch
from
a01148d to
e466d3f
Compare
bedrich-schindler
approved these changes
Mar 27, 2024
adamkudrna
force-pushed
the
feature/css-cascade-layers
branch
from
e466d3f to
789560c
Compare
As long as `layers.scss` (layers order definition) is called first, our Sass styles can be imported in any order. It solves the incorrect (but unavoidable, due to the way we compile CSS) call order of styles in our `index.js`. Also, developers can now extend the CSS cascade instead of just prepending or appending their styles to ours. For example: ```css /* My custom app styles */ @layer foundation.elements { code { background-color: silver; } } ```
adamkudrna
force-pushed
the
feature/css-cascade-layers
branch
from
789560c to
45212f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as
layers.scss(layers order definition) is called first, our Sass styles can be imported in any order.It solves the incorrect (but unavoidable, due to the way we compile CSS) call order of styles in our
index.js.Also, developers can now extend the CSS cascade instead of just prepending or appending their styles to ours.
For example:
*.module.scss, the development class names have been renamed from<ComponentName>__<hash>to<ComponentName>-module__<hash>.Closes #518.