Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native <dialog> element for Modal #461

Open
hubacekj opened this issue Apr 14, 2023 · 0 comments · May be fixed by #544
Open

Use native <dialog> element for Modal #461

hubacekj opened this issue Apr 14, 2023 · 0 comments · May be fixed by #544
Assignees
@bedrich-schindler
Labels
BC Breaking change feature
Milestone
v1.0.0

Comments

@hubacekj
Copy link
Contributor

hubacekj commented Apr 14, 2023 •
edited
Loading

We want to migrate Modal currently using div to native <dialog> element.

Relevant links:
#432 (comment)
#453
@hubacekj hubacekj converted this from a draft issue Apr 14, 2023
This was referenced Apr 14, 2023
Closed
Merged
@hubacekj hubacekj added this to the v1.0.0 milestone Apr 14, 2023
@hubacekj hubacekj added BC Breaking change feature labels Apr 14, 2023
@adamkudrna adamkudrna mentioned this issue Aug 7, 2023
Closed
@mbohal mbohal mentioned this issue Sep 26, 2023
Closed
@bedrich-schindler bedrich-schindler self-assigned this May 30, 2024
bedrich-schindler added a commit that referenced this issue May 30, 2024
@bedrich-schindler
Re-implement Modal component using HTMLDialogElement (#461)
77224ee
@bedrich-schindler bedrich-schindler linked a pull request May 30, 2024 that will close this issue
Open
bedrich-schindler added a commit that referenced this issue May 31, 2024
@bedrich-schindler
[WIP] Replace jsdom with happy-dom testing environment to enable …
7ad19e6 
…`Modal` tests (#461)
bedrich-schindler added a commit that referenced this issue Jun 1, 2024
@bedrich-schindler
fixup! [WIP] Replace jsdom with happy-dom testing environment to …
9151d36 
…enable `Modal` tests (#461)
@bedrich-schindler bedrich-schindler moved this from 🔖 To do to 🏗 In progress in The Board Jun 1, 2024
bedrich-schindler added a commit that referenced this issue Jun 6, 2024
@bedrich-schindler
fixup! Re-implement Modal component using HTMLDialogElement (#461)
8d6ac22
@adamkudrna adamkudrna moved this from 🏗 In progress to 👀 In review in The Board Jun 17, 2024
bedrich-schindler added a commit that referenced this issue Aug 31, 2024
@bedrich-schindler
fixup! fixup! Re-implement Modal component using HTMLDialogElement (#…
64ae3d4 
…461)
bedrich-schindler added a commit that referenced this issue Sep 8, 2024
@bedrich-schindler
fixup! fixup! fixup! Re-implement Modal component using HTMLDialogE…
06a7018 
…lement (#461)
bedrich-schindler added a commit that referenced this issue Sep 8, 2024
@bedrich-schindler
fixup! fixup! fixup! fixup! Re-implement Modal component using HTML…
6348886 
…DialogElement (#461)
bedrich-schindler added a commit that referenced this issue Sep 24, 2024
@bedrich-schindler
fixup! fixup! fixup! fixup! fixup! Re-implement Modal component usi…
4f137dd 
…ng HTMLDialogElement (#461)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bedrich-schindler bedrich-schindler

Labels
BC Breaking change feature
Projects
The Board
Status: 👀 In review
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Re-implement Modal component using HTMLDialogElement (#461) react-ui-org/react-ui
2 participants
@bedrich-schindler @hubacekj