We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presently there is no officially stated startegy where HTML attributes should be forwarded to.
@dacerondrej did a good job unifying it in https://react-ui.io/components/popover#forwarding-html-attributes, but in order to provide a good DX we need a stated strategy.
The current state is following:
Alert root Badge root Button interactive/root ButtonGroup root Card root CardBody root CardFooter root ` CheckboxField interactive FileInputField interactive FormLayout root FormLayoutCustomField root Grid root GridSpan root InputGroup root Modal modal, not backdrop ModalBody root ModalCloseButton interactive/root ModalContent root ModalFooter root ModalHeader root ModalTitle root Paper root Popover root PopoverWrapper root Radio root ScrollView root SelectField interactive Table root Tabs root TabsItem root Text root TextArea interactive TextField interactive TextLink interactive/root Toggle interactive Toolbar root ToolbarGroup root ToolbarItem root
root = the root node of the component interactive = the interactive element in the composition - it might or might not be the root node
root
interactive
The problematic ones are:
Radio
onChange
Modal
<dialog>
TabsItem
The text was updated successfully, but these errors were encountered:
@adamkudrna Would #461 fix this issue? In other words would that issue allow us to make the <dialog> HTML element the root of our <Modal> component?
<Modal>
I think it should be possible, because for backdrop we could use https://developer.mozilla.org/en-US/docs/Web/CSS/::backdrop, but I'm not sure.
Sorry, something went wrong.
In other words would that issue allow us to make the <dialog> HTML element the root of our <Modal> component?
Yes!
mbohal
No branches or pull requests
Presently there is no officially stated startegy where HTML attributes should be forwarded to.
@dacerondrej did a good job unifying it in https://react-ui.io/components/popover#forwarding-html-attributes, but in order to provide a good DX we need a stated strategy.
The current state is following:
root
= the root node of the componentinteractive
= the interactive element in the composition - it might or might not be the root nodeThe problematic ones are:
Radio
-> will be fixed in Move theonChange
handler back toRadio
inputs #481Modal
->I don't know what to do wit this one…will be fixed in Use native<dialog>
element forModal
#461TabsItem
-> Should be fixed hereThe text was updated successfully, but these errors were encountered: