Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

Feature/showing connecting status on answering a call #45

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

aarkalyk
Copy link
Contributor

@aarkalyk aarkalyk commented Jul 6, 2018

With introducing this PR, on answering a call user will see connecting status and updateConnectionStatus method will need to be called to indicate either start or failure of a call.
This will only work if showConnectionState argument is passed to displayIncomingCall, otherwise a call will just get connected immediately as it does in the current version.

Solves the issue #22

@ckrodrigues
Copy link

@ianlin this seems really useful, can you take a look at it?

@zxcpoiu
Copy link
Member

zxcpoiu commented Sep 7, 2018

@aarkalyk

Hi, Does this introduce a breaking change?
Said, what would happen if a user use the older version and does not call updateConnectionStatus ?

@aarkalyk
Copy link
Contributor Author

aarkalyk commented Dec 15, 2018

@zxcpoiu Just introduced some changes. There shouldn't be any breaking changes now.
@ianlin Can you take a look please?

@zek
Copy link

zek commented Apr 8, 2019

@aarkalyk I tried your PR. It works as below but If I updateConnectionState after connection is established no one can hear each other. Do you have any solutions for this problem?

      NativeModules.RNCallKeep.updateConnectionState(true);
      if (data.callUUID) {
        this.callManager.getSession(data.callUUID).acceptCall();
      } else {
        this.callManager.incomingSession.acceptCall();
      }

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants