Skip to content

Commit

Permalink
Add missing hasVideo attribute
Browse files Browse the repository at this point in the history
  • Loading branch information
manuquentin committed Apr 28, 2022
1 parent d55d326 commit 2ba0c6c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ public ReactApplicationContext getContext() {

public void reportNewIncomingCall(String uuid, String number, String callerName, boolean hasVideo, String payload) {
Log.d(TAG, "[RNCallKeepModule] reportNewIncomingCall, uuid: " + uuid + ", number: " + number + ", callerName: " + callerName);
// @TODO: handle video

this.displayIncomingCall(uuid, number, callerName, hasVideo);

Expand All @@ -188,6 +187,7 @@ public void reportNewIncomingCall(String uuid, String number, String callerName,
args.putString("handle", number);
args.putString("callUUID", uuid);
args.putString("name", callerName);
args.putString("hasVideo", hasVideo);
if (payload != null) {
args.putString("payload", payload);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,9 @@ private Boolean canMakeOutgoingCall() {

private Connection createConnection(ConnectionRequest request) {
Bundle extras = request.getExtras();
if (request.getAddress() == null) {
return null;
}
HashMap<String, String> extrasMap = this.bundleToMap(extras);

String callerNumber = request.getAddress().toString();
Expand Down

2 comments on commit 2ba0c6c

@codeion
Copy link

@codeion codeion commented on 2ba0c6c May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/react-native-callkeep/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java:190:
error: incompatible types: boolean cannot be converted to java.lang.String
args.putString("hasVideo", hasVideo); -> args.putString("hasVideo", String.valueOf(hasVideo));

@manuquentin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! I'll fix that on master

Please sign in to comment.