Fixed issue with hermes and prototype.toString #814
Conversation
|
hello and thanks for the PR! The code we have there is a little odd, so this change probably makes sense... But there's a PR which I think is changing it and I'd like to get that one in first. On another note, I'm not sure the explanation you gave is correct, I think for some reason, in your code, |
|
You're right, my fix doesn't directly address the error message. It still fixes the crash in my specific case. I don't have the time to provide you with a minimal reproducible example, sorry. Here's what I tried: // trying to reproduce the following message:
// TypeError: Object is not a function, js engine: hermes, stack:
// simple test
const value = new Date();
print(Object.prototype.toString.call(value));
// copying additional behavior from datetimepicker
const options = {
a: new Date(),
b: null,
c: undefined,
};
const keys = [ 'a', 'b', 'c', 'd' ];
keys.forEach(function each(key) {
const value = options[key];
// if (value instanceof Date) {
if (Object.prototype.toString.call(value) === '[object Date]') {
print('found date');
}
});The PR you linked made exactly the same change I did, so feel free to close my PR. |
I was running into issues when rendering the datetimepicker on Android in release mode only (dev worked fine).
Opening the Picker crashed my app (stacktrace attached).
Looking through the trace, i narrowed it down to an issue with the line
if (Object.prototype.toString.call(value) === '[object Date]') {intoMillisecondsinutils.js.Wondering why this might be an issue and knowing that "release mode only" bugs are often related to hermes, I found that using
Function.prototype.toStringis not supported when using hermes (Source: https://hermesengine.dev/docs/language-features/#miscellaneous-incompatibilities).I therefore changed the way dates are detected. It works for me now.