Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github action to scan code #700

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add github action to scan code #700

wants to merge 2 commits into from
+26 −1

Conversation

luancurti
Copy link
Member

Summary

Scan code using SonarCloud

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅ ❌
Android ✅ ❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@luancurti luancurti added the enhancement New feature or request label Dec 2, 2022
@luancurti luancurti requested a review from vonovak December 2, 2022 12:33
@luancurti luancurti self-assigned this Dec 2, 2022
@luancurti luancurti force-pushed the chore/add-sonarcloud branch from 64bad21 to ad5a312 Compare December 2, 2022 12:41
@luancurti luancurti force-pushed the chore/add-sonarcloud branch 2 times, most recently from 1ca9352 to 5ef2cec Compare December 2, 2022 13:28
@luancurti luancurti force-pushed the chore/add-sonarcloud branch from 5ef2cec to c842c54 Compare December 2, 2022 14:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vonovak
Copy link
Member

vonovak commented Dec 25, 2022

Hello and thanks @luancurti!
Is there anything I should know to be able to maintain this integration? Feel free to get in touch on discord, thanks 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vonovak vonovak Awaiting requested review from vonovak

Assignees

@luancurti luancurti

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luancurti @vonovak