-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: additional Gmail validation #1193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PsypherPunk
force-pushed
the
937-gmail-validation
branch
from
October 4, 2022 22:01
36deb1f
to
869232e
Compare
PsypherPunk
commented
Oct 4, 2022
PsypherPunk
commented
Oct 4, 2022
amaury1093
reviewed
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I tested it locally and it works well, thanks! Just a final nit
amaury1093
reviewed
Oct 5, 2022
- check the validity of `gmail.com`/`googlemail.com` email addresses via the method outlined [here](https://blog.0day.rocks/abusing-gmail-to-get-previously-unlisted-e-mail-addresses-41544b62b2). - run only via the `--gmail-use-api`/`gmail_use_api` flags (defaulting to `false`.) relates reacherhq#937
move the `create_client` method to a separate file; have the `yahoo` and `gmail` modules reference this.
PsypherPunk
force-pushed
the
937-gmail-validation
branch
from
October 5, 2022 19:26
b2d4c25
to
99b2ac7
Compare
verify Gmail HTTP API behaviour with `[email protected]`, failure indicating that the API is no longer reliable.
should check as per the MX host: - for gmail.com or googlemail.com, this will look like `*.gmail-smtp-in.l.google.com.`. - for Google Apps/Workspace domains, this will look like `*.aspmx.l.google.com.`.
amaury1093
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @PsypherPunk!
8 tasks
juhniorsantos
pushed a commit
to juhniorsantos/check-if-email-exists
that referenced
this pull request
Apr 11, 2024
* feat: additional Gmail validation - check the validity of `gmail.com`/`googlemail.com` email addresses via the method outlined [here](https://blog.0day.rocks/abusing-gmail-to-get-previously-unlisted-e-mail-addresses-41544b62b2). - run only via the `--gmail-use-api`/`gmail_use_api` flags (defaulting to `false`.) relates reacherhq#937 * refactor: split out HTTP client move the `create_client` method to a separate file; have the `yahoo` and `gmail` modules reference this. * test: add test for Gmail HTTP API verify Gmail HTTP API behaviour with `[email protected]`, failure indicating that the API is no longer reliable. * fix: correct host checks for Gmail HTTP API should check as per the MX host: - for gmail.com or googlemail.com, this will look like `*.gmail-smtp-in.l.google.com.`. - for Google Apps/Workspace domains, this will look like `*.aspmx.l.google.com.`. Co-authored-by: PsypherPunk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gmail.com
/googlemail.com
email addresses via the method outlined here.--gmail-use-api
/gmail_use_api
flags (defaulting tofalse
.)relates #937