Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional Gmail validation #1193

Merged
merged 4 commits into from
Oct 6, 2022

Conversation

PsypherPunk
Copy link
Contributor

  • check the validity of gmail.com/googlemail.com email addresses via the method outlined here.
  • run only via the --gmail-use-api/gmail_use_api flags (defaulting to false.)

relates #937

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2022

CLA assistant check
All committers have signed the CLA.

@PsypherPunk PsypherPunk force-pushed the 937-gmail-validation branch from 36deb1f to 869232e Compare October 4, 2022 22:01
core/src/smtp/gmail.rs Outdated Show resolved Hide resolved
core/src/smtp/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I tested it locally and it works well, thanks! Just a final nit

core/src/smtp/gmail.rs Outdated Show resolved Hide resolved
PsypherPunk and others added 2 commits October 5, 2022 20:25
- check the validity of `gmail.com`/`googlemail.com` email addresses via
  the method outlined
  [here](https://blog.0day.rocks/abusing-gmail-to-get-previously-unlisted-e-mail-addresses-41544b62b2).
- run only via the `--gmail-use-api`/`gmail_use_api` flags (defaulting
  to `false`.)

relates reacherhq#937
move the `create_client` method to a separate file; have the `yahoo` and
`gmail` modules reference this.
@PsypherPunk PsypherPunk force-pushed the 937-gmail-validation branch from b2d4c25 to 99b2ac7 Compare October 5, 2022 19:26
verify Gmail HTTP API behaviour with `[email protected]`, failure
indicating that the API is no longer reliable.
should check as per the MX host:

- for gmail.com or googlemail.com, this will look like
  `*.gmail-smtp-in.l.google.com.`.
- for Google Apps/Workspace domains, this will look like
  `*.aspmx.l.google.com.`.
Copy link
Member

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @PsypherPunk!

@amaury1093 amaury1093 merged commit 49c8f5c into reacherhq:master Oct 6, 2022
@PsypherPunk PsypherPunk deleted the 937-gmail-validation branch October 6, 2022 14:45
juhniorsantos pushed a commit to juhniorsantos/check-if-email-exists that referenced this pull request Apr 11, 2024
* feat: additional Gmail validation

- check the validity of `gmail.com`/`googlemail.com` email addresses via
  the method outlined
  [here](https://blog.0day.rocks/abusing-gmail-to-get-previously-unlisted-e-mail-addresses-41544b62b2).
- run only via the `--gmail-use-api`/`gmail_use_api` flags (defaulting
  to `false`.)

relates reacherhq#937

* refactor: split out HTTP client

move the `create_client` method to a separate file; have the `yahoo` and
`gmail` modules reference this.

* test: add test for Gmail HTTP API

verify Gmail HTTP API behaviour with `[email protected]`, failure
indicating that the API is no longer reliable.

* fix: correct host checks for Gmail HTTP API

should check as per the MX host:

- for gmail.com or googlemail.com, this will look like
  `*.gmail-smtp-in.l.google.com.`.
- for Google Apps/Workspace domains, this will look like
  `*.aspmx.l.google.com.`.

Co-authored-by: PsypherPunk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants