-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor development setup #11
chore: refactor development setup #11
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
I don't see a button with "Workflow(s) awaiting approval", maybe it needs to "Ready for Review" first? https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve workflow
it's there, I dont know what else to try now |
This comment was marked as resolved.
This comment was marked as resolved.
yes thanks, made a mistake with the |
How should this be tested? Should I copy and paste? |
You need the stuff in https://github.com/rdmorganiser/rdmo-catalog to thest this plugin properly. We could clone and setup rdmo in the CI of this repo here, ingest the RDMO catalog (and domain, etc.) and run a few exports/imports. |
Ruff complains about lines being too long. |
I don't understand. Can you explain what needs to be done? |
I would like to merge this PR. I am going to ignore the long lines warnings. |
Can I merge this @MyPyDavid @jochenklar? |
I have no time to check this right now, but I trust you :D |
I would merge, but I don't have the permissions on this repo. |
Related issue: #7, #8
Tasks
version = "1.0.1"