Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor development setup #11

Merged
merged 5 commits into from
Nov 28, 2023
Merged

chore: refactor development setup #11

merged 5 commits into from
Nov 28, 2023

Conversation

afuetterer
Copy link
Member

@afuetterer afuetterer commented Oct 17, 2023

Related issue: #7, #8

Tasks

  • enable CI
  • squash commits
  • init.py only contains version = "1.0.1"
  • create atomic commits
  • deal with E501 Line too long, break lines or ignore?

@afuetterer afuetterer marked this pull request as draft October 17, 2023 08:31
rdmo_plugins/__init__.py Outdated Show resolved Hide resolved
rdmo_plugins/__init__.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@afuetterer

This comment was marked as resolved.

@MyPyDavid
Copy link
Member

I don't see a button with "Workflow(s) awaiting approval", maybe it needs to "Ready for Review" first?
I can check it

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

@MyPyDavid MyPyDavid marked this pull request as ready for review October 17, 2023 09:29
@afuetterer

This comment was marked as resolved.

Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve workflow

@MyPyDavid
Copy link
Member

I guess there needs to be .github/workflows on master?

it's there, I dont know what else to try now

@afuetterer

This comment was marked as resolved.

@MyPyDavid
Copy link
Member

Needed a rebase. Now CI runs, thanks. I will remove your django.yml, okay? There is no manage.py in this repo.

yes thanks, made a mistake with the django.yml, now its running!

@afuetterer afuetterer marked this pull request as draft October 17, 2023 09:46
@afuetterer
Copy link
Member Author

How should this be tested?
I can install rdmo and rdmo-plugins in CI and add a few tests. But I need the testing setup and the fixtures from the main rdmo repo.

Should I copy and paste?
Should the testing setup and fixtures become their own repo?

@jochenklar
Copy link
Member

You need the stuff in https://github.com/rdmorganiser/rdmo-catalog to thest this plugin properly. We could clone and setup rdmo in the CI of this repo here, ingest the RDMO catalog (and domain, etc.) and run a few exports/imports.

@afuetterer
Copy link
Member Author

Ruff complains about lines being too long.

@afuetterer
Copy link
Member Author

You need the stuff in https://github.com/rdmorganiser/rdmo-catalog to thest this plugin properly. We could clone and setup rdmo in the CI of this repo here, ingest the RDMO catalog (and domain, etc.) and run a few exports/imports.

I don't understand.

Can you explain what needs to be done?

@afuetterer afuetterer marked this pull request as ready for review November 20, 2023 08:53
@afuetterer
Copy link
Member Author

afuetterer commented Nov 24, 2023

I would like to merge this PR. I am going to ignore the long lines warnings.
Opened a new issue about that: #14

@afuetterer
Copy link
Member Author

Can I merge this @MyPyDavid @jochenklar?

@jochenklar
Copy link
Member

I have no time to check this right now, but I trust you :D

@afuetterer
Copy link
Member Author

I would merge, but I don't have the permissions on this repo.

@jochenklar jochenklar merged commit 00d3e94 into rdmorganiser:master Nov 28, 2023
5 checks passed
@afuetterer afuetterer deleted the 7-development-setup branch November 28, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants