SERXIONE-6196: DeviceIdentification activation fail #5910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: DeviceIdentification plugin activation fail Test Procedure:Check DeviceIdentification plugin activation. Risks: Low Signed-off-by:AkshayKumar_Gampa [email protected]
srikanth-vv
requested changes
Dec 3, 2024
| @@ -20,6 +20,18 @@ | |||
| #include "DeviceIdentification.h" | |||
| #include "IdentityProvider.h" | |||
| #include <interfaces/IConfiguration.h> | |||
| #include "tracing/Logging.h" | |||
| #include "UtilsJsonRpc.h" | |||
| #include <com/com.h> | |||
There was a problem hiding this comment.
Check if you need all these header files. I think ids.h is not needed. What about com.h, core.h?
| } | ||
| if ((Utils::getServiceState(_service, "DeviceInfo", state) == Core::ERROR_NONE) && (state == PluginHost::IShell::state::ACTIVATED)) | ||
| { | ||
| auto _remoteDeviceInfoObject = _service->QueryInterfaceByCallsign<Exchange::IDeviceInfo>("DeviceInfo"); |
There was a problem hiding this comment.
What is case of non USE_THUNDER_R4? Do you have to handle differently?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: DeviceIdentification plugin activation fail
Test Procedure:Check DeviceIdentification plugin activation.
Risks: Low
Signed-off-by:AkshayKumar_Gampa [email protected]