Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ODM specific APIs from TvSettings HAL to make it generic #5894

Open
wants to merge 3 commits into
base: sprint/24Q4
Choose a base branch
from

Conversation

arjunbinu
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ arjunbinu
❌ arjunbinusky
You have signed the CLA already but the status is still pending? Let us recheck it.

opt_path.append(filename);

if(!boost::filesystem::exists( opt_path)) {
std::cout << "DS HAL : Using " << m_path <<std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the print

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Will change the print and update.

public:
CIniFile(const std::string & filename, const std::string & filepath = "/etc/" )
{
opt_path = "/opt/panel/";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this override path holds good for tvsettings use case?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its generic path for config file overriding for PQ Module.
aml-pqserver, TvSettings,AVOuptut using this path for overriding.

Copy link
Author

@arjunbinu arjunbinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go through the responses.

public:
CIniFile(const std::string & filename, const std::string & filepath = "/etc/" )
{
opt_path = "/opt/panel/";
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its generic path for config file overriding for PQ Module.
aml-pqserver, TvSettings,AVOuptut using this path for overriding.

opt_path.append(filename);

if(!boost::filesystem::exists( opt_path)) {
std::cout << "DS HAL : Using " << m_path <<std::endl;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Will change the print and update.

@utkarshece14
Copy link

Removed redundant ODM APIs. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants