-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ODM specific APIs from TvSettings HAL to make it generic #5894
base: sprint/24Q4
Are you sure you want to change the base?
Conversation
|
38b62cb
to
8e6665c
Compare
AVOutput/AVOutputTV.h
Outdated
opt_path.append(filename); | ||
|
||
if(!boost::filesystem::exists( opt_path)) { | ||
std::cout << "DS HAL : Using " << m_path <<std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the print
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Will change the print and update.
public: | ||
CIniFile(const std::string & filename, const std::string & filepath = "/etc/" ) | ||
{ | ||
opt_path = "/opt/panel/"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this override path holds good for tvsettings use case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its generic path for config file overriding for PQ Module.
aml-pqserver, TvSettings,AVOuptut using this path for overriding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go through the responses.
public: | ||
CIniFile(const std::string & filename, const std::string & filepath = "/etc/" ) | ||
{ | ||
opt_path = "/opt/panel/"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its generic path for config file overriding for PQ Module.
aml-pqserver, TvSettings,AVOuptut using this path for overriding.
AVOutput/AVOutputTV.h
Outdated
opt_path.append(filename); | ||
|
||
if(!boost::filesystem::exists( opt_path)) { | ||
std::cout << "DS HAL : Using " << m_path <<std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Will change the print and update.
Removed redundant ODM APIs. Approved. |
No description provided.