HALTVSettings - Improper pic_modes_t assignment in GetTVSupportedPic…

[slkanthi]

…tureModes

As per the current tvsettings.h interface, the prototype for the GetTVSupportedPictureModes function is:

tvError_t GetTVSupportedPictureModes(pic_modes_t *pictureModes[], unsigned short *count);

In the tvsettings implementation, the parameter pic_modes_t *pictureModes[] is declared as an array of pointers to pic_modes_t, but it is being assigned a pointer to an array of structures, which is incorrect.

*pictureModes = availableModes;

This assignment sets only the 0th index of the pictureModes array to point to the entire array of structures, whereas the expected behavior is for each index in pictureModes[] to point to individual structures in the pic_modes array:

pictureModes[index] = &pic_modes[index];

The pictureModes[] parameter should thus be populated with pointers to individual pic_modes_t structures, not with a single pointer to the entire array.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

skk451 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}