clang19 compatibility #1465
Merged
clang19 compatibility #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me...
|
CMakeLists.txt
Outdated
| @@ -269,6 +272,9 @@ find_package(Boost REQUIRED COMPONENTS filesystem system thread iostreams) | |||
| set(OPENRAVE_BOOST_INCLUDE_DIRS ${Boost_INCLUDE_DIRS}) | |||
| set(OPENRAVE_BOOST_LIB_DIRS ${Boost_LIBRARY_DIRS}) | |||
|
|
|||
| # prevents CLANG from "error: integer value -1 is outside the valid range of values [0, 3] for the enumeration type 'sign_mixture_enum' [-Wenum-constexpr-conversion]" | |||
| include_directories(SYSTEM ${OPENRAVE_BOOST_INCLUDE_DIRS}) | |||
There was a problem hiding this comment.
@lazydroid do you still need this?
There was a problem hiding this comment.
@yoshikikanemoto it's not strictly required for suppressing -Wenum-constexpr-conversion errors, however, it should help to reduce warning noise coming from Boost and maybe other system includes.
If you think this should be removed, I shall remove it.
There was a problem hiding this comment.
@yoshikikanemoto this part is gone.
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang19 treats
-Wenum-constexpr-conversionas an error by default, and gives the following message:in case of a simple warning adding to the system includes should work with:
but it does not in this case, hence the need of disabling this particular error directly.