Added all signals, exit with child exit code, reap all remaining pid's #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for sending this! Also, could you create a CONTRIBUTORS.txt and add your name to it? |
| // the spawned child just terminated | ||
| debug_print("child_died:%d\n", pid); | ||
| return 0; | ||
| debug_print("child_pid exited: %d\n", status); |
There was a problem hiding this comment.
The python tests make assertions based on these messages. If you want to update this message you should update the tests as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the following changes:
docker/pkg/signal/signal_linux.gofile (with the exception of SIGKILL and SIGSTOP), which should now be passed to the child process.waitpid(-1, NULL, WNOHANG)to avoid child processes of your child process not being reaped.WEXITSTATUS(cstatus);