preload checkout modal #313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| const styleNode = document.createElement('style'); | ||
| styleNode.type = 'text/css'; | ||
| styleNode.innerHTML = styleSnippet; |
There was a problem hiding this comment.
User controlled data in a styleNode.innerHTML is an anti-pattern that can lead to XSS vulnerabilities (Line 276)
🔴 Fix or ignore this finding to merge your pull request.
🙈 From insecure-innerhtml.
| window.MagicCheckout.showModal = function() { | ||
| const modal = document.createElement('div'); | ||
| modal.id = 'magic-wrapper'; | ||
| modal.innerHTML = htmlSnippet; |
There was a problem hiding this comment.
User controlled data in a modal.innerHTML is an anti-pattern that can lead to XSS vulnerabilities (Line 285)
🔴 Fix or ignore this finding to merge your pull request.
🙈 From insecure-innerhtml.
angbpy
approved these changes
Jul 14, 2022
poojarazor
force-pushed
the
1cc-shimmer-checkout
branch
from
e1341d2
to
0cc2173
Compare
poojarazor
force-pushed
the
1cc-shimmer-checkout
branch
from
0cc2173
to
4eaf82f
Compare
angbpy
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.