Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix:Edit Subscription function name change #225

Open
wants to merge 86 commits into
base: master
Choose a base branch
from
Open

BugFix:Edit Subscription function name change #225

wants to merge 86 commits into from

Conversation

sid10on10
Copy link

Razorpay documentation states that the subscription should be updated -
client.subscription.update(subscriptionId, options)

Reference - https://razorpay.com/docs/api/payments/subscriptions/#update-a-subscription

So Edit subscription Function should be named to update

Related Issue - #224

javeeth and others added 30 commits February 22, 2022 16:15
@javeeth
semgrep integration
066f721
@thotakartheek004
changes
f2ff14a
@thotakartheek004
nosemgrep
d69ba9f
@thotakartheek004
nosemgrep
fff9839
@thotakartheek004
nosemgrep
6d7f4fa
@thotakartheek004
changes
83f3013
@thotakartheek004
changes
5dcf626
@thotakartheek004
changes
12b73b7
@thotakartheek004
Merge pull request razorpay#186 from razorpay/semgrep_integration
0352f2d 
semgrep integration
@ankitdas13
otp implement
a214b89
@ankitdas13
customer doc correction
35fb125
@ankitdas13
order doc correction
27eb2ed
@ankitdas13
fund doc correction
ecd194f
@ankitdas13
token doc correction
6b0c8c1
@ankitdas13
add fund link param
4744454
@ankitdas13
payment doc correction
75792d9
@ankitdas13
settlement doc correction
dc2ae1f
@ankitdas13
refund doc correction
a4b3cb8
@ankitdas13
fixed invoice doc
ce6936d
@ankitdas13
added tpv order
7fa65e4
@ankitdas13
added tpv payment
364b2f7
@ankitdas13
added tpv token
a03715d
@ankitdas13
fixed accourding comment
a051d9b
@ankitdas13
fixed according comments
f902b05
@ankitdas13
create order update parameter
5e7d0ce
@ankitdas13
fixed according comments
6239273
@ankitdas13
fixed according doc
d993031
@ankitdas13
fixed according doc
3d8286e
@ankitdas13
fixing according doc
f238092
@ankitdas13
update paramter & response
554eb55
ankitdas13 and others added 20 commits July 1, 2022 18:51
@ankitdas13
Merge pull request razorpay#209 from razorpay/emandate_doc_correction
fbbaca9 
Emandate doc correction
@ankitdas13
Merge pull request razorpay#210 from razorpay/card_doc_correction
2585bf8 
Card doc correction
@ankitdas13
Merge pull request razorpay#211 from razorpay/papernach_doc_correction
c2dfd57 
Papernach correction
@ankitdas13
Merge pull request razorpay#212 from razorpay/registernach_doc_correc…
9509b12 
…tion

Registernach doc correction
@ankitdas13
Merge pull request razorpay#213 from razorpay/upi_doc_correction
6f1d209 
Upi doc correction
@ankitdas13
Merge pull request razorpay#214 from razorpay/registerEmandate_doc_co…
b4fd63f 
…rrection

RegisterEmandate doc correction
@ankitdas13
Merge pull request razorpay#217 from razorpay/item_doc_correction
7b1fd09 
item doc correction
@ankitdas13
Merge pull request razorpay#218 from razorpay/subscription_doc_correc…
2cb9fb4 
…tion

subscription doc correction
@ankitdas13
Merge pull request razorpay#219 from razorpay/paymentlink_doc_correction
26ff1ca 
paymentlink doc correction
@ankitdas13
Merge pull request razorpay#220 from razorpay/smartcollect_doc_correc…
3b6b884 
…tion

smartcollect doc correction
@ankitdas13
Merge pull request razorpay#221 from razorpay/transfer_doc_correction
17eb991 
transfer doc correction
@ankitdas13
Merge pull request razorpay#200 from razorpay/third_party_validation_…
53d3755 
…payment

Third party validation Payment
@ankitdas13
Merge branch 'doc_api_correction' into third_party_validation
c6dec90
@ankitdas13
Merge pull request razorpay#199 from razorpay/third_party_validation
53a8bb4 
Third party validation
@ankitdas13
Merge pull request razorpay#216 from razorpay/addon_api_correction
af83bd7 
addon doc correction
@ankitdas13
update version
da7e26c
@ankitdas13
Merge pull request razorpay#193 from razorpay/doc_api_correction
912da6a 
Doc api correction
@ankitdas13
create order params updated
1da7ed3
@ankitdas13
Merge pull request razorpay#222 from razorpay/papernach_param
bd024a6 
create order params updated
@sid10on10
edit function name change
84952c1
@kkyusufk kkyusufk self-assigned this Aug 30, 2022
@kkyusufk
Copy link

You will need to update the unit tests for the checks to pass.

@sid10on10
Copy link
Author

@kkyusufk I have updated the test cases. You can review and merge.

@kkyusufk
Copy link

kkyusufk commented Sep 1, 2022

@sid10on10 Looks good!
Will review this with other folks and hopefully this should be merged by tomorrow.
Thanks for the contribution! 😄

@sid10on10
Copy link
Author

@kkyusufk I want to contribute more to Razorpay Python.Let me know the best things to get started.

@kkyusufk
Copy link

kkyusufk commented Sep 3, 2022

started

Hi @sid10on10, Thanks for your interest in contributing.
During the course of the next couple of weeks, we will be adding some agenda items and a roadmap for features we would want to add to this sdk.
We will open some issues which can be picked by anyone either from razorpay or outside razorpay.
So keep an eye on that issues filter 😄

@sid10on10
Copy link
Author

sid10on10 commented Sep 5, 2022 •
edited
Loading

@ankitdas13 @kkyusufk Thanks for the feedback. I look forward to contributing.

@sid10on10 sid10on10 changed the title Edit Subscription function name change BugFix:Edit Subscription function name change Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kkyusufk kkyusufk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sid10on10 @kkyusufk @decached @javeeth @thotakartheek004 @ankitdas13