Merge pull request #172 from ray-di/hotfix

Fix getNamedArguments when parameter has default value

composer.json

@@ -49,7 +49,7 @@
         "cs-fix": ["./vendor/bin/phpcbf src tests"],
         "clean": ["./vendor/bin/phpstan clear-result-cache", "./vendor/bin/psalm --clear-cache", "rm -rf tests/tmp/*.php"],
         "sa": ["./vendor/bin/phpstan analyse -c phpstan.neon", "psalm --show-info=true"],
-        "metrics": ["./vendor/bin/phpmetrics --report-html=build/metrics --exclude=Exception --log-junit=build/junit.xml --junit=build/junit.xml src"],
+        "metrics": ["./vendor/bin/phpmetrics --report-html=build/metrics --exclude=Exception src"],
         "phpmd": ["./vendor/bin/phpmd src text ./phpmd.xml"],
         "build": ["@cs", "@sa", "@pcov", "@metrics"]
     }

src/ReflectiveMethodInvocation.php

@@ -85,8 +85,11 @@ public function getNamedArguments(): ArrayObject
         $params = $this->getMethod()->getParameters();
         $namedParams = [];
         foreach ($params as $param) {
-            /** @psalm-suppress MixedAssignment */
-            $namedParams[$param->getName()] = $args[$param->getPosition()];
+            $pos = $param->getPosition();
+            if (isset($args[$pos])) {
+                /** @psalm-suppress MixedAssignment */
+                $namedParams[$param->getName()] = $args[$pos];
+            }
         }
 
         return new ArrayObject($namedParams);

tests/Fake/FakeClass.php

@@ -45,4 +45,8 @@ public function getTriple(int $c): int
     {
         return $c * 3;
     }
+
+    public function defaultValue(int $a = 1)
+    {
+    }
 }

tests/ReflectiveMethodInvocationTest.php

@@ -85,6 +85,16 @@ public function testGetNamedArguments(): void
         $this->assertSame((array) $args, ['n' => 1]);
     }
 
+    /**
+     * @covers ReflectiveMethodInvocation::getNamedArguments
+     */
+    public function testGetNamedArgumentsWithDefaultValue(): void
+    {
+        $invocation = new ReflectiveMethodInvocation(new FakeWeavedClass(), 'defaultValue', [], [new FakeInterceptor(), new FakeInterceptor()]);
+        $args = $invocation->getNamedArguments();
+        $this->assertSame((array) $args, []);
+    }
+
     public function testGetAnnotation(): void
     {
         $fakeMarker = $this->invocation->getMethod()->getAnnotation(FakeMarker::class);